Post-Commit Reviews

Pre-Commit Code Review Workflows

Code Reviews and Developer Velocity

  • CI run all tests of a project in a matter of seconds
  • turnaround time for code review is in the order of a few seconds

Post-Commit Reviews

Post-Commit Reviews != Post-Deployment Reviews

Post-Commit Pre-Deploy Reviews
  • leaving code-review to be the very last step of the deployment pipeline, before the code is deployed to production
  • or in cases where it’s not necessary for an audit-trail or mandatory sign-off on changes (for prototype projects, internal tools that don’t handle customer sensitive data and so forth), for code review to happen post-deployment.

Benefits of Post-Commit Reviews

Focus

Encourages Better Development Practices

  • a culture of collaborating on aspects like API design prior to code implementation via a design document.
  • consensus around aspects like style-guide, coding idioms, concurrency primitives etc.
  • investment in better automation practices and tooling.

Post-Commit Reviews Can Detect More Bugs Before Code Review

Challenges of Post-Commit Reviews

High-Functioning, High-Trust Environments

Investment in Automation

Conclusion

  • post-commit, pre-deploy reviews
  • post-commit, post-deploy reviews

--

--

--

@copyconstruct on Twitter. views expressed on this blog are solely mine, not those of present or past employers.

Love podcasts or audiobooks? Learn on the go with our new app.

Recommended from Medium

Git Workflows

Resilient Kubernetes Deployments with Readiness Probes

Tactical Challenges In Hiring Junior Engineers

Time Complexity Analysis

Why you can’t compare LeSS to any scaling Framework like SAFe

Hybrid Cloud Migration 101: The Importance of Creating a Single Enterprise Pipeline

Hacking Type Erasure with Super Type Token

Software development has no obligation to make sense to developers

Get the Medium app

A button that says 'Download on the App Store', and if clicked it will lead you to the iOS App store
A button that says 'Get it on, Google Play', and if clicked it will lead you to the Google Play store
Cindy Sridharan

Cindy Sridharan

@copyconstruct on Twitter. views expressed on this blog are solely mine, not those of present or past employers.

More from Medium

How to help your team deliver continuously

The Staging Dichotomy: Part One

The Staging Dichotomy: Part One Cover Image

How to Grow Engineering Team Tenfold without Sacrificing Test Health

Best of 2021 in Tech [Talks]